attune-system/attune
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

artifact management

Browse Source
This commit is contained in:
David Culbreth
2026-03-03 14:16:23 -06:00
parent 8299e5efcb
commit b54aa3ec26
15 changed files with 980 additions and 411 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
crates/api/src/dto/artifact.rs
View File

@@ -105,6 +105,9 @@ pub struct UpdateArtifactRequest {
/// Updated content type /// Updated content type
pub content_type: Option<String>, pub content_type: Option<String>,
/// Updated execution ID (re-links artifact to a different execution)
pub execution: Option<i64>,
/// Updated structured data (replaces existing data entirely) /// Updated structured data (replaces existing data entirely)
pub data: Option<JsonValue>, pub data: Option<JsonValue>,
} }

3
crates/api/src/routes/actions.rs
View File

@@ -237,6 +237,9 @@ pub async fn update_action(
runtime_version_constraint: request.runtime_version_constraint, runtime_version_constraint: request.runtime_version_constraint,
param_schema: request.param_schema, param_schema: request.param_schema,
out_schema: request.out_schema, out_schema: request.out_schema,
parameter_delivery: None,
parameter_format: None,
output_format: None,
}; };
let action = ActionRepository::update(&state.db, existing_action.id, update_input).await?; let action = ActionRepository::update(&state.db, existing_action.id, update_input).await?;

286
crates/api/src/routes/artifacts.rs
View File

@@ -8,6 +8,7 @@
//! - Progress append for progress-type artifacts (streaming updates) //! - Progress append for progress-type artifacts (streaming updates)
//! - Listing artifacts by execution //! - Listing artifacts by execution
//! - Version history and retrieval //! - Version history and retrieval
//! - Upsert-and-upload: create-or-reuse an artifact by ref and upload a version in one call
use axum::{ use axum::{
body::Body, body::Body,
@@ -20,7 +21,9 @@ use axum::{
use std::sync::Arc; use std::sync::Arc;
use tracing::warn; use tracing::warn;
use attune_common::models::enums::{ArtifactType, ArtifactVisibility}; use attune_common::models::enums::{
ArtifactType, ArtifactVisibility, OwnerType, RetentionPolicyType,
};
use attune_common::repositories::{ use attune_common::repositories::{
artifact::{ artifact::{
ArtifactRepository, ArtifactSearchFilters, ArtifactVersionRepository, CreateArtifactInput, ArtifactRepository, ArtifactSearchFilters, ArtifactVersionRepository, CreateArtifactInput,
@@ -251,6 +254,7 @@ pub async fn update_artifact(
description: request.description, description: request.description,
content_type: request.content_type, content_type: request.content_type,
size_bytes: None, // Managed by version creation trigger size_bytes: None, // Managed by version creation trigger
execution: request.execution.map(Some),
data: request.data, data: request.data,
}; };
@@ -970,6 +974,282 @@ pub async fn delete_version(
)) ))
} }
// ============================================================================
// Upsert-and-upload by ref
// ============================================================================
/// Upload a file version to an artifact identified by ref, creating the artifact if it does not
/// already exist.
///
/// This is the recommended way for actions to produce versioned file artifacts. The caller
/// provides the artifact ref and file content in a single multipart request. The server:
///
/// 1. Looks up the artifact by `ref`.
/// 2. If not found, creates it using the metadata fields in the multipart body.
/// 3. If found, optionally updates the `execution` link to the current execution.
/// 4. Uploads the file bytes as a new version (version number is auto-assigned).
///
/// **Multipart fields:**
/// - `file` (required) — the binary file content
/// - `ref` (required for creation) — artifact reference (ignored if artifact already exists)
/// - `scope` — owner scope: `system`, `pack`, `action`, `sensor`, `rule` (default: `action`)
/// - `owner` — owner identifier (default: empty string)
/// - `type` — artifact type: `file_text`, `file_image`, etc. (default: `file_text`)
/// - `visibility` — `public` or `private` (default: type-aware server default)
/// - `name` — human-readable name
/// - `description` — optional description
/// - `content_type` — MIME type (default: auto-detected from multipart or `application/octet-stream`)
/// - `execution` — execution ID to link this artifact to (updates existing artifacts too)
/// - `retention_policy` — `versions`, `days`, `hours`, `minutes` (default: `versions`)
/// - `retention_limit` — limit value (default: `10`)
/// - `created_by` — who created this version
/// - `meta` — JSON metadata for this version
#[utoipa::path(
post,
path = "/api/v1/artifacts/ref/{ref}/versions/upload",
tag = "artifacts",
params(("ref" = String, Path, description = "Artifact reference (created if not found)")),
request_body(content = String, content_type = "multipart/form-data"),
responses(
(status = 201, description = "Version created (artifact may have been created too)", body = inline(ApiResponse<ArtifactVersionResponse>)),
(status = 400, description = "Missing file field or invalid metadata"),
(status = 413, description = "File too large"),
),
security(("bearer_auth" = []))
)]
pub async fn upload_version_by_ref(
RequireAuth(_user): RequireAuth,
State(state): State<Arc<AppState>>,
Path(artifact_ref): Path<String>,
mut multipart: Multipart,
) -> ApiResult<impl IntoResponse> {
// 50 MB limit
const MAX_FILE_SIZE: usize = 50 * 1024 * 1024;
// Collect all multipart fields
let mut file_data: Option<Vec<u8>> = None;
let mut file_content_type: Option<String> = None;
let mut content_type_field: Option<String> = None;
let mut meta: Option<serde_json::Value> = None;
let mut created_by: Option<String> = None;
// Artifact-creation metadata (used only when creating a new artifact)
let mut scope: Option<String> = None;
let mut owner: Option<String> = None;
let mut artifact_type: Option<String> = None;
let mut visibility: Option<String> = None;
let mut name: Option<String> = None;
let mut description: Option<String> = None;
let mut execution: Option<String> = None;
let mut retention_policy: Option<String> = None;
let mut retention_limit: Option<String> = None;
while let Some(field) = multipart
.next_field()
.await
.map_err(|e| ApiError::BadRequest(format!("Multipart error: {}", e)))?
{
let field_name = field.name().unwrap_or("").to_string();
match field_name.as_str() {
"file" => {
file_content_type = field.content_type().map(|s| s.to_string());
let bytes = field
.bytes()
.await
.map_err(|e| ApiError::BadRequest(format!("Failed to read file: {}", e)))?;
if bytes.len() > MAX_FILE_SIZE {
return Err(ApiError::BadRequest(format!(
"File exceeds maximum size of {} bytes",
MAX_FILE_SIZE
)));
}
file_data = Some(bytes.to_vec());
}
"content_type" => {
let t = field.text().await.unwrap_or_default();
if !t.is_empty() {
content_type_field = Some(t);
}
}
"meta" => {
let t = field.text().await.unwrap_or_default();
if !t.is_empty() {
meta =
Some(serde_json::from_str(&t).map_err(|e| {
ApiError::BadRequest(format!("Invalid meta JSON: {}", e))
})?);
}
}
"created_by" => {
let t = field.text().await.unwrap_or_default();
if !t.is_empty() {
created_by = Some(t);
}
}
"scope" => {
scope = Some(field.text().await.unwrap_or_default());
}
"owner" => {
owner = Some(field.text().await.unwrap_or_default());
}
"type" => {
artifact_type = Some(field.text().await.unwrap_or_default());
}
"visibility" => {
visibility = Some(field.text().await.unwrap_or_default());
}
"name" => {
name = Some(field.text().await.unwrap_or_default());
}
"description" => {
description = Some(field.text().await.unwrap_or_default());
}
"execution" => {
execution = Some(field.text().await.unwrap_or_default());
}
"retention_policy" => {
retention_policy = Some(field.text().await.unwrap_or_default());
}
"retention_limit" => {
retention_limit = Some(field.text().await.unwrap_or_default());
}
_ => { /* skip unknown fields */ }
}
}
let file_bytes = file_data.ok_or_else(|| {
ApiError::BadRequest("Missing required 'file' field in multipart upload".to_string())
})?;
// Parse execution ID
let execution_id: Option<i64> = match &execution {
Some(s) if !s.is_empty() => Some(
s.parse::<i64>()
.map_err(|_| ApiError::BadRequest(format!("Invalid execution ID: '{}'", s)))?,
),
_ => None,
};
// Upsert: find existing artifact or create a new one
let artifact = match ArtifactRepository::find_by_ref(&state.db, &artifact_ref).await? {
Some(existing) => {
// Update execution link if a new execution ID was provided
if execution_id.is_some() && execution_id != existing.execution {
let update_input = UpdateArtifactInput {
r#ref: None,
scope: None,
owner: None,
r#type: None,
visibility: None,
retention_policy: None,
retention_limit: None,
name: None,
description: None,
content_type: None,
size_bytes: None,
execution: execution_id.map(Some),
data: None,
};
ArtifactRepository::update(&state.db, existing.id, update_input).await?
} else {
existing
}
}
None => {
// Parse artifact type
let a_type: ArtifactType = match &artifact_type {
Some(t) => serde_json::from_value(serde_json::Value::String(t.clone()))
.map_err(|_| ApiError::BadRequest(format!("Invalid artifact type: '{}'", t)))?,
None => ArtifactType::FileText,
};
// Parse scope
let a_scope: OwnerType = match &scope {
Some(s) if !s.is_empty() => {
serde_json::from_value(serde_json::Value::String(s.clone()))
.map_err(|_| ApiError::BadRequest(format!("Invalid scope: '{}'", s)))?
}
_ => OwnerType::Action,
};
// Parse visibility with type-aware default
let a_visibility: ArtifactVisibility = match &visibility {
Some(v) if !v.is_empty() => {
serde_json::from_value(serde_json::Value::String(v.clone()))
.map_err(|_| ApiError::BadRequest(format!("Invalid visibility: '{}'", v)))?
}
_ => {
if a_type == ArtifactType::Progress {
ArtifactVisibility::Public
} else {
ArtifactVisibility::Private
}
}
};
// Parse retention
let a_retention_policy: RetentionPolicyType = match &retention_policy {
Some(rp) if !rp.is_empty() => {
serde_json::from_value(serde_json::Value::String(rp.clone())).map_err(|_| {
ApiError::BadRequest(format!("Invalid retention_policy: '{}'", rp))
})?
}
_ => RetentionPolicyType::Versions,
};
let a_retention_limit: i32 = match &retention_limit {
Some(rl) if !rl.is_empty() => rl.parse::<i32>().map_err(|_| {
ApiError::BadRequest(format!("Invalid retention_limit: '{}'", rl))
})?,
_ => 10,
};
let create_input = CreateArtifactInput {
r#ref: artifact_ref.clone(),
scope: a_scope,
owner: owner.unwrap_or_default(),
r#type: a_type,
visibility: a_visibility,
retention_policy: a_retention_policy,
retention_limit: a_retention_limit,
name: name.filter(|s| !s.is_empty()),
description: description.filter(|s| !s.is_empty()),
content_type: content_type_field
.clone()
.or_else(|| file_content_type.clone()),
execution: execution_id,
data: None,
};
ArtifactRepository::create(&state.db, create_input).await?
}
};
// Resolve content type: explicit field > multipart header > fallback
let resolved_ct = content_type_field
.or(file_content_type)
.unwrap_or_else(|| "application/octet-stream".to_string());
let version_input = CreateArtifactVersionInput {
artifact: artifact.id,
content_type: Some(resolved_ct),
content: Some(file_bytes),
content_json: None,
file_path: None,
meta,
created_by,
};
let version = ArtifactVersionRepository::create(&state.db, version_input).await?;
Ok((
StatusCode::CREATED,
Json(ApiResponse::with_message(
ArtifactVersionResponse::from(version),
"Version uploaded successfully",
)),
))
}
// ============================================================================ // ============================================================================
// Helpers // Helpers
// ============================================================================ // ============================================================================
@@ -1219,6 +1499,10 @@ pub fn routes() -> Router<Arc<AppState>> {
.delete(delete_artifact), .delete(delete_artifact),
) )
.route("/artifacts/ref/{ref}", get(get_artifact_by_ref)) .route("/artifacts/ref/{ref}", get(get_artifact_by_ref))
.route(
"/artifacts/ref/{ref}/versions/upload",
post(upload_version_by_ref),
)
// Progress / data // Progress / data
.route("/artifacts/{id}/progress", post(append_progress)) .route("/artifacts/{id}/progress", post(append_progress))
.route( .route(

302
crates/api/src/routes/packs.rs
View File

@@ -14,10 +14,7 @@ use validator::Validate;
use attune_common::models::pack_test::PackTestResult; use attune_common::models::pack_test::PackTestResult;
use attune_common::mq::{MessageEnvelope, MessageType, PackRegisteredPayload}; use attune_common::mq::{MessageEnvelope, MessageType, PackRegisteredPayload};
use attune_common::repositories::{ use attune_common::repositories::{
action::ActionRepository,
pack::{CreatePackInput, UpdatePackInput}, pack::{CreatePackInput, UpdatePackInput},
rule::{RestoreRuleInput, RuleRepository},
trigger::TriggerRepository,
Create, Delete, FindById, FindByRef, PackRepository, PackTestRepository, Pagination, Update, Create, Delete, FindById, FindByRef, PackRepository, PackTestRepository, Pagination, Update,
}; };
use attune_common::workflow::{PackWorkflowService, PackWorkflowServiceConfig}; use attune_common::workflow::{PackWorkflowService, PackWorkflowServiceConfig};
@@ -732,85 +729,100 @@ async fn register_pack_internal(
.and_then(|v| v.as_str()) .and_then(|v| v.as_str())
.map(|s| s.to_string()); .map(|s| s.to_string());
// Ad-hoc rules to restore after pack reinstallation // Extract common metadata fields used for both create and update
let mut saved_adhoc_rules: Vec<attune_common::models::rule::Rule> = Vec::new(); let conf_schema = pack_yaml
.get("config_schema")
.and_then(|v| serde_json::to_value(v).ok())
.unwrap_or_else(|| serde_json::json!({}));
let meta = pack_yaml
.get("metadata")
.and_then(|v| serde_json::to_value(v).ok())
.unwrap_or_else(|| serde_json::json!({}));
let tags: Vec<String> = pack_yaml
.get("keywords")
.and_then(|v| v.as_sequence())
.map(|seq| {
seq.iter()
.filter_map(|v| v.as_str().map(|s| s.to_string()))
.collect()
})
.unwrap_or_default();
let runtime_deps: Vec<String> = pack_yaml
.get("runtime_deps")
.and_then(|v| v.as_sequence())
.map(|seq| {
seq.iter()
.filter_map(|v| v.as_str().map(|s| s.to_string()))
.collect()
})
.unwrap_or_default();
let dependencies: Vec<String> = pack_yaml
.get("dependencies")
.and_then(|v| v.as_sequence())
.map(|seq| {
seq.iter()
.filter_map(|v| v.as_str().map(|s| s.to_string()))
.collect()
})
.unwrap_or_default();
// Check if pack already exists // Check if pack already exists — update in place to preserve IDs
if !force { let existing_pack = PackRepository::find_by_ref(&state.db, &pack_ref).await?;
if PackRepository::exists_by_ref(&state.db, &pack_ref).await? {
let is_new_pack;
let pack = if let Some(existing) = existing_pack {
if !force {
return Err(ApiError::Conflict(format!( return Err(ApiError::Conflict(format!(
"Pack '{}' already exists. Use force=true to reinstall.", "Pack '{}' already exists. Use force=true to reinstall.",
pack_ref pack_ref
))); )));
} }
// Update existing pack in place — preserves pack ID and all child entity IDs
let update_input = UpdatePackInput {
label: Some(label),
description: Some(description.unwrap_or_default()),
version: Some(version.clone()),
conf_schema: Some(conf_schema),
config: None, // preserve user-set config
meta: Some(meta),
tags: Some(tags),
runtime_deps: Some(runtime_deps),
dependencies: Some(dependencies),
is_standard: None,
installers: None,
};
let updated = PackRepository::update(&state.db, existing.id, update_input).await?;
tracing::info!(
"Updated existing pack '{}' (ID: {}) in place",
pack_ref,
updated.id
);
is_new_pack = false;
updated
} else { } else {
// Delete existing pack if force is true, preserving ad-hoc (user-created) rules // Create new pack
if let Some(existing_pack) = PackRepository::find_by_ref(&state.db, &pack_ref).await? { let pack_input = CreatePackInput {
// Save ad-hoc rules before deletion — CASCADE on pack FK would destroy them r#ref: pack_ref.clone(),
saved_adhoc_rules = RuleRepository::find_adhoc_by_pack(&state.db, existing_pack.id) label,
.await description,
.unwrap_or_default(); version: version.clone(),
if !saved_adhoc_rules.is_empty() { conf_schema,
tracing::info!( config: serde_json::json!({}),
"Preserving {} ad-hoc rule(s) during reinstall of pack '{}'", meta,
saved_adhoc_rules.len(), tags,
pack_ref runtime_deps,
); dependencies,
} is_standard: false,
installers: serde_json::json!({}),
};
PackRepository::delete(&state.db, existing_pack.id).await?; is_new_pack = true;
tracing::info!("Deleted existing pack '{}' for forced reinstall", pack_ref); PackRepository::create(&state.db, pack_input).await?
}
}
// Create pack input
let pack_input = CreatePackInput {
r#ref: pack_ref.clone(),
label,
description,
version: version.clone(),
conf_schema: pack_yaml
.get("config_schema")
.and_then(|v| serde_json::to_value(v).ok())
.unwrap_or_else(|| serde_json::json!({})),
config: serde_json::json!({}),
meta: pack_yaml
.get("metadata")
.and_then(|v| serde_json::to_value(v).ok())
.unwrap_or_else(|| serde_json::json!({})),
tags: pack_yaml
.get("keywords")
.and_then(|v| v.as_sequence())
.map(|seq| {
seq.iter()
.filter_map(|v| v.as_str().map(|s| s.to_string()))
.collect()
})
.unwrap_or_default(),
runtime_deps: pack_yaml
.get("runtime_deps")
.and_then(|v| v.as_sequence())
.map(|seq| {
seq.iter()
.filter_map(|v| v.as_str().map(|s| s.to_string()))
.collect()
})
.unwrap_or_default(),
dependencies: pack_yaml
.get("dependencies")
.and_then(|v| v.as_sequence())
.map(|seq| {
seq.iter()
.filter_map(|v| v.as_str().map(|s| s.to_string()))
.collect()
})
.unwrap_or_default(),
is_standard: false,
installers: serde_json::json!({}),
}; };
let pack = PackRepository::create(&state.db, pack_input).await?;
// Auto-sync workflows after pack creation // Auto-sync workflows after pack creation
let packs_base_dir = PathBuf::from(&state.config.packs_base_dir); let packs_base_dir = PathBuf::from(&state.config.packs_base_dir);
let service_config = PackWorkflowServiceConfig { let service_config = PackWorkflowServiceConfig {
@@ -850,14 +862,18 @@ async fn register_pack_internal(
match component_loader.load_all(&pack_path).await { match component_loader.load_all(&pack_path).await {
Ok(load_result) => { Ok(load_result) => {
tracing::info!( tracing::info!(
"Pack '{}' components loaded: {} runtimes, {} triggers, {} actions, {} sensors ({} skipped, {} warnings)", "Pack '{}' components loaded: {} created, {} updated, {} skipped, {} removed, {} warnings \
(runtimes: {}/{}, triggers: {}/{}, actions: {}/{}, sensors: {}/{})",
pack.r#ref, pack.r#ref,
load_result.runtimes_loaded, load_result.total_loaded(),
load_result.triggers_loaded, load_result.total_updated(),
load_result.actions_loaded,
load_result.sensors_loaded,
load_result.total_skipped(), load_result.total_skipped(),
load_result.warnings.len() load_result.removed,
load_result.warnings.len(),
load_result.runtimes_loaded, load_result.runtimes_updated,
load_result.triggers_loaded, load_result.triggers_updated,
load_result.actions_loaded, load_result.actions_updated,
load_result.sensors_loaded, load_result.sensors_updated,
); );
for warning in &load_result.warnings { for warning in &load_result.warnings {
tracing::warn!("Pack component warning: {}", warning); tracing::warn!("Pack component warning: {}", warning);
@@ -873,122 +889,9 @@ async fn register_pack_internal(
} }
} }
// Restore ad-hoc rules that were saved before pack deletion, and // Since entities are now updated in place (IDs preserved), ad-hoc rules
// re-link any rules from other packs whose action/trigger FKs were // and cross-pack FK references survive reinstallation automatically.
// set to NULL when the old pack's entities were cascade-deleted. // No need to save/restore rules or re-link FKs.
{
// Phase 1: Restore saved ad-hoc rules
if !saved_adhoc_rules.is_empty() {
let mut restored = 0u32;
for saved_rule in &saved_adhoc_rules {
// Resolve action and trigger IDs by ref (they may have been recreated)
let action_id = ActionRepository::find_by_ref(&state.db, &saved_rule.action_ref)
.await
.ok()
.flatten()
.map(|a| a.id);
let trigger_id = TriggerRepository::find_by_ref(&state.db, &saved_rule.trigger_ref)
.await
.ok()
.flatten()
.map(|t| t.id);
let input = RestoreRuleInput {
r#ref: saved_rule.r#ref.clone(),
pack: pack.id,
pack_ref: pack.r#ref.clone(),
label: saved_rule.label.clone(),
description: saved_rule.description.clone(),
action: action_id,
action_ref: saved_rule.action_ref.clone(),
trigger: trigger_id,
trigger_ref: saved_rule.trigger_ref.clone(),
conditions: saved_rule.conditions.clone(),
action_params: saved_rule.action_params.clone(),
trigger_params: saved_rule.trigger_params.clone(),
enabled: saved_rule.enabled,
};
match RuleRepository::restore_rule(&state.db, input).await {
Ok(rule) => {
restored += 1;
if rule.action.is_none() || rule.trigger.is_none() {
tracing::warn!(
"Restored ad-hoc rule '{}' with unresolved references \
(action: {}, trigger: {})",
rule.r#ref,
if rule.action.is_some() {
"linked"
} else {
"NULL"
},
if rule.trigger.is_some() {
"linked"
} else {
"NULL"
},
);
}
}
Err(e) => {
tracing::warn!(
"Failed to restore ad-hoc rule '{}': {}",
saved_rule.r#ref,
e
);
}
}
}
tracing::info!(
"Restored {}/{} ad-hoc rule(s) for pack '{}'",
restored,
saved_adhoc_rules.len(),
pack.r#ref
);
}
// Phase 2: Re-link rules from other packs whose action/trigger FKs
// were set to NULL when the old pack's entities were cascade-deleted
let new_actions = ActionRepository::find_by_pack(&state.db, pack.id)
.await
.unwrap_or_default();
let new_triggers = TriggerRepository::find_by_pack(&state.db, pack.id)
.await
.unwrap_or_default();
for action in &new_actions {
match RuleRepository::relink_action_by_ref(&state.db, &action.r#ref, action.id).await {
Ok(count) if count > 0 => {
tracing::info!("Re-linked {} rule(s) to action '{}'", count, action.r#ref);
}
Err(e) => {
tracing::warn!(
"Failed to re-link rules to action '{}': {}",
action.r#ref,
e
);
}
_ => {}
}
}
for trigger in &new_triggers {
match RuleRepository::relink_trigger_by_ref(&state.db, &trigger.r#ref, trigger.id).await
{
Ok(count) if count > 0 => {
tracing::info!("Re-linked {} rule(s) to trigger '{}'", count, trigger.r#ref);
}
Err(e) => {
tracing::warn!(
"Failed to re-link rules to trigger '{}': {}",
trigger.r#ref,
e
);
}
_ => {}
}
}
}
// Set up runtime environments for the pack's actions. // Set up runtime environments for the pack's actions.
// This creates virtualenvs, installs dependencies, etc. based on each // This creates virtualenvs, installs dependencies, etc. based on each
@@ -1199,8 +1102,11 @@ async fn register_pack_internal(
let test_passed = result.status == "passed"; let test_passed = result.status == "passed";
if !test_passed && !force { if !test_passed && !force {
// Tests failed and force is not set - rollback pack creation // Tests failed and force is not set — only delete if we just created this pack.
let _ = PackRepository::delete(&state.db, pack.id).await; // If we updated an existing pack, deleting would destroy the original.
if is_new_pack {
let _ = PackRepository::delete(&state.db, pack.id).await;
}
return Err(ApiError::BadRequest(format!( return Err(ApiError::BadRequest(format!(
"Pack registration failed: tests did not pass. Use force=true to register anyway." "Pack registration failed: tests did not pass. Use force=true to register anyway."
))); )));
@@ -1217,7 +1123,9 @@ async fn register_pack_internal(
tracing::warn!("Failed to execute tests for pack '{}': {}", pack.r#ref, e); tracing::warn!("Failed to execute tests for pack '{}': {}", pack.r#ref, e);
// If tests can't be executed and force is not set, fail the registration // If tests can't be executed and force is not set, fail the registration
if !force { if !force {
let _ = PackRepository::delete(&state.db, pack.id).await; if is_new_pack {
let _ = PackRepository::delete(&state.db, pack.id).await;
}
return Err(ApiError::BadRequest(format!( return Err(ApiError::BadRequest(format!(
"Pack registration failed: could not execute tests. Error: {}. Use force=true to register anyway.", "Pack registration failed: could not execute tests. Error: {}. Use force=true to register anyway.",
e e

6
crates/api/src/routes/workflows.rs
View File

@@ -669,6 +669,9 @@ async fn update_companion_action(
runtime_version_constraint: None, runtime_version_constraint: None,
param_schema: param_schema.cloned(), param_schema: param_schema.cloned(),
out_schema: out_schema.cloned(), out_schema: out_schema.cloned(),
parameter_delivery: None,
parameter_format: None,
output_format: None,
}; };
ActionRepository::update(db, action.id, update_input) ActionRepository::update(db, action.id, update_input)
@@ -731,6 +734,9 @@ async fn ensure_companion_action(
runtime_version_constraint: None, runtime_version_constraint: None,
param_schema: param_schema.cloned(), param_schema: param_schema.cloned(),
out_schema: out_schema.cloned(), out_schema: out_schema.cloned(),
parameter_delivery: None,
parameter_format: None,
output_format: None,
}; };
ActionRepository::update(db, action.id, update_input) ActionRepository::update(db, action.id, update_input)

483
crates/common/src/pack_registry/loader.rs
View File

@@ -9,6 +9,11 @@
//! 2. Triggers (no dependencies) //! 2. Triggers (no dependencies)
//! 3. Actions (depend on runtime) //! 3. Actions (depend on runtime)
//! 4. Sensors (depend on triggers and runtime) //! 4. Sensors (depend on triggers and runtime)
//!
//! All loaders use **upsert** semantics: if an entity with the same ref already
//! exists it is updated in place (preserving its database ID); otherwise a new
//! row is created. After loading, entities that belong to the pack but whose
//! refs are no longer present in the YAML files are deleted.
use std::collections::HashMap; use std::collections::HashMap;
use std::path::Path; use std::path::Path;
@@ -18,34 +23,47 @@ use tracing::{info, warn};
use crate::error::{Error, Result}; use crate::error::{Error, Result};
use crate::models::Id; use crate::models::Id;
use crate::repositories::action::ActionRepository; use crate::repositories::action::{ActionRepository, UpdateActionInput};
use crate::repositories::runtime::{CreateRuntimeInput, RuntimeRepository}; use crate::repositories::runtime::{CreateRuntimeInput, RuntimeRepository, UpdateRuntimeInput};
use crate::repositories::runtime_version::{CreateRuntimeVersionInput, RuntimeVersionRepository}; use crate::repositories::runtime_version::{
use crate::repositories::trigger::{ CreateRuntimeVersionInput, RuntimeVersionRepository, UpdateRuntimeVersionInput,
CreateSensorInput, CreateTriggerInput, SensorRepository, TriggerRepository,
}; };
use crate::repositories::{Create, FindById, FindByRef, Update}; use crate::repositories::trigger::{
CreateSensorInput, CreateTriggerInput, SensorRepository, TriggerRepository, UpdateSensorInput,
UpdateTriggerInput,
};
use crate::repositories::{Create, Delete, FindById, FindByRef, Update};
use crate::version_matching::extract_version_components; use crate::version_matching::extract_version_components;
/// Result of loading pack components into the database. /// Result of loading pack components into the database.
#[derive(Debug, Default)] #[derive(Debug, Default)]
pub struct PackLoadResult { pub struct PackLoadResult {
/// Number of runtimes loaded /// Number of runtimes created
pub runtimes_loaded: usize, pub runtimes_loaded: usize,
/// Number of runtimes skipped (already exist) /// Number of runtimes updated (already existed)
pub runtimes_updated: usize,
/// Number of runtimes skipped due to errors
pub runtimes_skipped: usize, pub runtimes_skipped: usize,
/// Number of triggers loaded /// Number of triggers created
pub triggers_loaded: usize, pub triggers_loaded: usize,
/// Number of triggers skipped (already exist) /// Number of triggers updated
pub triggers_updated: usize,
/// Number of triggers skipped
pub triggers_skipped: usize, pub triggers_skipped: usize,
/// Number of actions loaded /// Number of actions created
pub actions_loaded: usize, pub actions_loaded: usize,
/// Number of actions skipped (already exist) /// Number of actions updated
pub actions_updated: usize,
/// Number of actions skipped
pub actions_skipped: usize, pub actions_skipped: usize,
/// Number of sensors loaded /// Number of sensors created
pub sensors_loaded: usize, pub sensors_loaded: usize,
/// Number of sensors skipped (already exist) /// Number of sensors updated
pub sensors_updated: usize,
/// Number of sensors skipped
pub sensors_skipped: usize, pub sensors_skipped: usize,
/// Number of stale entities removed
pub removed: usize,
/// Warnings encountered during loading /// Warnings encountered during loading
pub warnings: Vec<String>, pub warnings: Vec<String>,
} }
@@ -58,6 +76,10 @@ impl PackLoadResult {
pub fn total_skipped(&self) -> usize { pub fn total_skipped(&self) -> usize {
self.runtimes_skipped + self.triggers_skipped + self.actions_skipped + self.sensors_skipped self.runtimes_skipped + self.triggers_skipped + self.actions_skipped + self.sensors_skipped
} }
pub fn total_updated(&self) -> usize {
self.runtimes_updated + self.triggers_updated + self.actions_updated + self.sensors_updated
}
} }
/// Loads pack components (triggers, actions, sensors) from YAML files on disk /// Loads pack components (triggers, actions, sensors) from YAML files on disk
@@ -79,9 +101,10 @@ impl<'a> PackComponentLoader<'a> {
/// Load all components from the pack directory. /// Load all components from the pack directory.
/// ///
/// Reads triggers, actions, and sensors from their respective subdirectories /// Uses upsert semantics: entities that already exist (by ref) are updated
/// and registers them in the database. Components that already exist (by ref) /// in place, preserving their database IDs. New entities are created.
/// are skipped. /// After loading, entities that belong to the pack but are no longer
/// present in the YAML files are removed.
pub async fn load_all(&self, pack_dir: &Path) -> Result<PackLoadResult> { pub async fn load_all(&self, pack_dir: &Path) -> Result<PackLoadResult> {
let mut result = PackLoadResult::default(); let mut result = PackLoadResult::default();
@@ -92,43 +115,60 @@ impl<'a> PackComponentLoader<'a> {
); );
// 1. Load runtimes first (no dependencies) // 1. Load runtimes first (no dependencies)
self.load_runtimes(pack_dir, &mut result).await?; let runtime_refs = self.load_runtimes(pack_dir, &mut result).await?;
// 2. Load triggers (no dependencies) // 2. Load triggers (no dependencies)
let trigger_ids = self.load_triggers(pack_dir, &mut result).await?; let (trigger_ids, trigger_refs) = self.load_triggers(pack_dir, &mut result).await?;
// 3. Load actions (depend on runtime) // 3. Load actions (depend on runtime)
self.load_actions(pack_dir, &mut result).await?; let action_refs = self.load_actions(pack_dir, &mut result).await?;
// 4. Load sensors (depend on triggers and runtime) // 4. Load sensors (depend on triggers and runtime)
self.load_sensors(pack_dir, &trigger_ids, &mut result) let sensor_refs = self
.load_sensors(pack_dir, &trigger_ids, &mut result)
.await?; .await?;
// 5. Clean up entities that are no longer in the pack's YAML files
self.cleanup_removed_entities(
&runtime_refs,
&trigger_refs,
&action_refs,
&sensor_refs,
&mut result,
)
.await;
info!( info!(
"Pack '{}' component loading complete: {} loaded, {} skipped, {} warnings", "Pack '{}' component loading complete: {} created, {} updated, {} skipped, {} removed, {} warnings",
self.pack_ref, self.pack_ref,
result.total_loaded(), result.total_loaded(),
result.total_updated(),
result.total_skipped(), result.total_skipped(),
result.removed,
result.warnings.len() result.warnings.len()
); );
Ok(result) Ok(result)
} }
/// Load trigger definitions from `pack_dir/triggers/*.yaml`.
///
/// Returns a map of trigger ref -> trigger ID for use by sensor loading.
/// Load runtime definitions from `pack_dir/runtimes/*.yaml`. /// Load runtime definitions from `pack_dir/runtimes/*.yaml`.
/// ///
/// Runtimes define how actions and sensors are executed (interpreter, /// Runtimes define how actions and sensors are executed (interpreter,
/// environment setup, dependency management). They are loaded first /// environment setup, dependency management). They are loaded first
/// since actions reference them. /// since actions reference them.
async fn load_runtimes(&self, pack_dir: &Path, result: &mut PackLoadResult) -> Result<()> { ///
/// Returns the set of runtime refs that were loaded (for cleanup).
async fn load_runtimes(
&self,
pack_dir: &Path,
result: &mut PackLoadResult,
) -> Result<Vec<String>> {
let runtimes_dir = pack_dir.join("runtimes"); let runtimes_dir = pack_dir.join("runtimes");
let mut loaded_refs = Vec::new();
if !runtimes_dir.exists() { if !runtimes_dir.exists() {
info!("No runtimes directory found for pack '{}'", self.pack_ref); info!("No runtimes directory found for pack '{}'", self.pack_ref);
return Ok(()); return Ok(loaded_refs);
} }
let yaml_files = read_yaml_files(&runtimes_dir)?; let yaml_files = read_yaml_files(&runtimes_dir)?;
@@ -153,16 +193,6 @@ impl<'a> PackComponentLoader<'a> {
} }
}; };
// Check if runtime already exists
if let Some(existing) = RuntimeRepository::find_by_ref(self.pool, &runtime_ref).await? {
info!(
"Runtime '{}' already exists (ID: {}), skipping",
runtime_ref, existing.id
);
result.runtimes_skipped += 1;
continue;
}
let name = data let name = data
.get("name") .get("name")
.and_then(|v| v.as_str()) .and_then(|v| v.as_str())
@@ -188,6 +218,35 @@ impl<'a> PackComponentLoader<'a> {
.and_then(|v| serde_json::to_value(v).ok()) .and_then(|v| serde_json::to_value(v).ok())
.unwrap_or_else(|| serde_json::json!({})); .unwrap_or_else(|| serde_json::json!({}));
// Check if runtime already exists — update in place if so
if let Some(existing) = RuntimeRepository::find_by_ref(self.pool, &runtime_ref).await? {
let update_input = UpdateRuntimeInput {
description,
name: Some(name),
distributions: Some(distributions),
installation,
execution_config: Some(execution_config),
};
match RuntimeRepository::update(self.pool, existing.id, update_input).await {
Ok(_) => {
info!("Updated runtime '{}' (ID: {})", runtime_ref, existing.id);
result.runtimes_updated += 1;
// Also upsert version entries
self.load_runtime_versions(&data, existing.id, &runtime_ref, result)
.await;
}
Err(e) => {
let msg = format!("Failed to update runtime '{}': {}", runtime_ref, e);
warn!("{}", msg);
result.warnings.push(msg);
}
}
loaded_refs.push(runtime_ref);
continue;
}
let input = CreateRuntimeInput { let input = CreateRuntimeInput {
r#ref: runtime_ref.clone(), r#ref: runtime_ref.clone(),
pack: Some(self.pack_id), pack: Some(self.pack_id),
@@ -203,6 +262,7 @@ impl<'a> PackComponentLoader<'a> {
Ok(rt) => { Ok(rt) => {
info!("Created runtime '{}' (ID: {})", runtime_ref, rt.id); info!("Created runtime '{}' (ID: {})", runtime_ref, rt.id);
result.runtimes_loaded += 1; result.runtimes_loaded += 1;
loaded_refs.push(runtime_ref.clone());
// Load version entries from the optional `versions` array // Load version entries from the optional `versions` array
self.load_runtime_versions(&data, rt.id, &runtime_ref, result) self.load_runtime_versions(&data, rt.id, &runtime_ref, result)
@@ -214,10 +274,11 @@ impl<'a> PackComponentLoader<'a> {
if let sqlx::Error::Database(ref inner) = db_err { if let sqlx::Error::Database(ref inner) = db_err {
if inner.is_unique_violation() { if inner.is_unique_violation() {
info!( info!(
"Runtime '{}' already exists (concurrent creation), skipping", "Runtime '{}' already exists (concurrent creation), treating as update",
runtime_ref runtime_ref
); );
result.runtimes_skipped += 1; loaded_refs.push(runtime_ref);
result.runtimes_updated += 1;
continue; continue;
} }
} }
@@ -229,29 +290,13 @@ impl<'a> PackComponentLoader<'a> {
} }
} }
Ok(()) Ok(loaded_refs)
} }
/// Load version entries from the `versions` array in a runtime YAML. /// Load runtime version entries from a runtime's YAML `versions` array.
/// ///
/// Each entry in the array describes a specific version of the runtime /// Uses upsert: existing versions (by runtime + version string) are updated,
/// with its own `execution_config` and `distributions`. Example: /// new versions are created.
///
/// ```yaml
/// versions:
/// - version: "3.12"
/// is_default: true
/// execution_config:
/// interpreter:
/// binary: python3.12
/// ...
/// distributions:
/// verification:
/// commands:
/// - binary: python3.12
/// args: ["--version"]
/// ...
/// ```
async fn load_runtime_versions( async fn load_runtime_versions(
&self, &self,
data: &serde_yaml_ng::Value, data: &serde_yaml_ng::Value,
@@ -270,6 +315,9 @@ impl<'a> PackComponentLoader<'a> {
runtime_ref runtime_ref
); );
// Collect version strings we loaded so we can clean up removed versions
let mut loaded_versions = Vec::new();
for entry in versions { for entry in versions {
let version_str = match entry.get("version").and_then(|v| v.as_str()) { let version_str = match entry.get("version").and_then(|v| v.as_str()) {
Some(v) => v.to_string(), Some(v) => v.to_string(),
@@ -284,21 +332,6 @@ impl<'a> PackComponentLoader<'a> {
} }
}; };
// Check if this version already exists
if let Ok(Some(_existing)) = RuntimeVersionRepository::find_by_runtime_and_version(
self.pool,
runtime_id,
&version_str,
)
.await
{
info!(
"Version '{}' for runtime '{}' already exists, skipping",
version_str, runtime_ref
);
continue;
}
let (version_major, version_minor, version_patch) = let (version_major, version_minor, version_patch) =
extract_version_components(&version_str); extract_version_components(&version_str);
@@ -322,6 +355,47 @@ impl<'a> PackComponentLoader<'a> {
.and_then(|v| serde_json::to_value(v).ok()) .and_then(|v| serde_json::to_value(v).ok())
.unwrap_or_else(|| serde_json::json!({})); .unwrap_or_else(|| serde_json::json!({}));
// Check if this version already exists — update in place if so
if let Ok(Some(existing)) = RuntimeVersionRepository::find_by_runtime_and_version(
self.pool,
runtime_id,
&version_str,
)
.await
{
let update_input = UpdateRuntimeVersionInput {
version: None, // version string doesn't change
version_major: Some(version_major),
version_minor: Some(version_minor),
version_patch: Some(version_patch),
execution_config: Some(execution_config),
distributions: Some(distributions),
is_default: Some(is_default),
available: None, // preserve current availability — verification sets this
verified_at: None,
meta: Some(meta),
};
match RuntimeVersionRepository::update(self.pool, existing.id, update_input).await {
Ok(_) => {
info!(
"Updated version '{}' for runtime '{}' (ID: {})",
version_str, runtime_ref, existing.id
);
}
Err(e) => {
let msg = format!(
"Failed to update version '{}' for runtime '{}': {}",
version_str, runtime_ref, e
);
warn!("{}", msg);
result.warnings.push(msg);
}
}
loaded_versions.push(version_str);
continue;
}
let input = CreateRuntimeVersionInput { let input = CreateRuntimeVersionInput {
runtime: runtime_id, runtime: runtime_id,
runtime_ref: runtime_ref.to_string(), runtime_ref: runtime_ref.to_string(),
@@ -342,6 +416,7 @@ impl<'a> PackComponentLoader<'a> {
"Created version '{}' for runtime '{}' (ID: {})", "Created version '{}' for runtime '{}' (ID: {})",
version_str, runtime_ref, rv.id version_str, runtime_ref, rv.id
); );
loaded_versions.push(version_str);
} }
Err(e) => { Err(e) => {
// Check for unique constraint violation (race condition) // Check for unique constraint violation (race condition)
@@ -352,6 +427,7 @@ impl<'a> PackComponentLoader<'a> {
"Version '{}' for runtime '{}' already exists (concurrent), skipping", "Version '{}' for runtime '{}' already exists (concurrent), skipping",
version_str, runtime_ref version_str, runtime_ref
); );
loaded_versions.push(version_str);
continue; continue;
} }
} }
@@ -365,19 +441,44 @@ impl<'a> PackComponentLoader<'a> {
} }
} }
} }
// Clean up versions that are no longer in the YAML
if let Ok(existing_versions) =
RuntimeVersionRepository::find_by_runtime(self.pool, runtime_id).await
{
for existing in existing_versions {
if !loaded_versions.contains(&existing.version) {
info!(
"Removing stale version '{}' for runtime '{}'",
existing.version, runtime_ref
);
if let Err(e) = RuntimeVersionRepository::delete(self.pool, existing.id).await {
warn!(
"Failed to delete stale version '{}' for runtime '{}': {}",
existing.version, runtime_ref, e
);
}
}
}
}
} }
/// Load trigger definitions from `pack_dir/triggers/*.yaml`.
///
/// Returns a map of trigger ref -> trigger ID for use by sensor loading,
/// and the list of loaded trigger refs for cleanup.
async fn load_triggers( async fn load_triggers(
&self, &self,
pack_dir: &Path, pack_dir: &Path,
result: &mut PackLoadResult, result: &mut PackLoadResult,
) -> Result<HashMap<String, Id>> { ) -> Result<(HashMap<String, Id>, Vec<String>)> {
let triggers_dir = pack_dir.join("triggers"); let triggers_dir = pack_dir.join("triggers");
let mut trigger_ids = HashMap::new(); let mut trigger_ids = HashMap::new();
let mut loaded_refs = Vec::new();
if !triggers_dir.exists() { if !triggers_dir.exists() {
info!("No triggers directory found for pack '{}'", self.pack_ref); info!("No triggers directory found for pack '{}'", self.pack_ref);
return Ok(trigger_ids); return Ok((trigger_ids, loaded_refs));
} }
let yaml_files = read_yaml_files(&triggers_dir)?; let yaml_files = read_yaml_files(&triggers_dir)?;
@@ -402,17 +503,6 @@ impl<'a> PackComponentLoader<'a> {
} }
}; };
// Check if trigger already exists
if let Some(existing) = TriggerRepository::find_by_ref(self.pool, &trigger_ref).await? {
info!(
"Trigger '{}' already exists (ID: {}), skipping",
trigger_ref, existing.id
);
trigger_ids.insert(trigger_ref, existing.id);
result.triggers_skipped += 1;
continue;
}
let name = extract_name_from_ref(&trigger_ref); let name = extract_name_from_ref(&trigger_ref);
let label = data let label = data
.get("label") .get("label")
@@ -439,6 +529,32 @@ impl<'a> PackComponentLoader<'a> {
.get("output") .get("output")
.and_then(|v| serde_json::to_value(v).ok()); .and_then(|v| serde_json::to_value(v).ok());
// Check if trigger already exists — update in place if so
if let Some(existing) = TriggerRepository::find_by_ref(self.pool, &trigger_ref).await? {
let update_input = UpdateTriggerInput {
label: Some(label),
description: Some(description),
enabled: Some(enabled),
param_schema,
out_schema,
};
match TriggerRepository::update(self.pool, existing.id, update_input).await {
Ok(_) => {
info!("Updated trigger '{}' (ID: {})", trigger_ref, existing.id);
result.triggers_updated += 1;
}
Err(e) => {
let msg = format!("Failed to update trigger '{}': {}", trigger_ref, e);
warn!("{}", msg);
result.warnings.push(msg);
}
}
trigger_ids.insert(trigger_ref.clone(), existing.id);
loaded_refs.push(trigger_ref);
continue;
}
let input = CreateTriggerInput { let input = CreateTriggerInput {
r#ref: trigger_ref.clone(), r#ref: trigger_ref.clone(),
pack: Some(self.pack_id), pack: Some(self.pack_id),
@@ -454,7 +570,8 @@ impl<'a> PackComponentLoader<'a> {
match TriggerRepository::create(self.pool, input).await { match TriggerRepository::create(self.pool, input).await {
Ok(trigger) => { Ok(trigger) => {
info!("Created trigger '{}' (ID: {})", trigger_ref, trigger.id); info!("Created trigger '{}' (ID: {})", trigger_ref, trigger.id);
trigger_ids.insert(trigger_ref, trigger.id); trigger_ids.insert(trigger_ref.clone(), trigger.id);
loaded_refs.push(trigger_ref);
result.triggers_loaded += 1; result.triggers_loaded += 1;
} }
Err(e) => { Err(e) => {
@@ -465,16 +582,23 @@ impl<'a> PackComponentLoader<'a> {
} }
} }
Ok(trigger_ids) Ok((trigger_ids, loaded_refs))
} }
/// Load action definitions from `pack_dir/actions/*.yaml`. /// Load action definitions from `pack_dir/actions/*.yaml`.
async fn load_actions(&self, pack_dir: &Path, result: &mut PackLoadResult) -> Result<()> { ///
/// Returns the list of loaded action refs for cleanup.
async fn load_actions(
&self,
pack_dir: &Path,
result: &mut PackLoadResult,
) -> Result<Vec<String>> {
let actions_dir = pack_dir.join("actions"); let actions_dir = pack_dir.join("actions");
let mut loaded_refs = Vec::new();
if !actions_dir.exists() { if !actions_dir.exists() {
info!("No actions directory found for pack '{}'", self.pack_ref); info!("No actions directory found for pack '{}'", self.pack_ref);
return Ok(()); return Ok(loaded_refs);
} }
let yaml_files = read_yaml_files(&actions_dir)?; let yaml_files = read_yaml_files(&actions_dir)?;
@@ -499,16 +623,6 @@ impl<'a> PackComponentLoader<'a> {
} }
}; };
// Check if action already exists
if let Some(existing) = ActionRepository::find_by_ref(self.pool, &action_ref).await? {
info!(
"Action '{}' already exists (ID: {}), skipping",
action_ref, existing.id
);
result.actions_skipped += 1;
continue;
}
let name = extract_name_from_ref(&action_ref); let name = extract_name_from_ref(&action_ref);
let label = data let label = data
.get("label") .get("label")
@@ -544,9 +658,6 @@ impl<'a> PackComponentLoader<'a> {
.get("output") .get("output")
.and_then(|v| serde_json::to_value(v).ok()); .and_then(|v| serde_json::to_value(v).ok());
// Read optional fields for parameter delivery/format and output format.
// The database has defaults (stdin, json, text), so we only set these
// in the INSERT if the YAML specifies them.
let parameter_delivery = data let parameter_delivery = data
.get("parameter_delivery") .get("parameter_delivery")
.and_then(|v| v.as_str()) .and_then(|v| v.as_str())
@@ -571,6 +682,36 @@ impl<'a> PackComponentLoader<'a> {
.and_then(|v| v.as_str()) .and_then(|v| v.as_str())
.map(|s| s.to_string()); .map(|s| s.to_string());
// Check if action already exists — update in place if so
if let Some(existing) = ActionRepository::find_by_ref(self.pool, &action_ref).await? {
let update_input = UpdateActionInput {
label: Some(label),
description: Some(description),
entrypoint: Some(entrypoint),
runtime: runtime_id,
runtime_version_constraint: Some(runtime_version_constraint),
param_schema,
out_schema,
parameter_delivery: Some(parameter_delivery),
parameter_format: Some(parameter_format),
output_format: Some(output_format),
};
match ActionRepository::update(self.pool, existing.id, update_input).await {
Ok(_) => {
info!("Updated action '{}' (ID: {})", action_ref, existing.id);
result.actions_updated += 1;
}
Err(e) => {
let msg = format!("Failed to update action '{}': {}", action_ref, e);
warn!("{}", msg);
result.warnings.push(msg);
}
}
loaded_refs.push(action_ref);
continue;
}
// Use raw SQL to include parameter_delivery, parameter_format, // Use raw SQL to include parameter_delivery, parameter_format,
// output_format which are not in CreateActionInput // output_format which are not in CreateActionInput
let create_result = sqlx::query_scalar::<_, i64>( let create_result = sqlx::query_scalar::<_, i64>(
@@ -604,6 +745,7 @@ impl<'a> PackComponentLoader<'a> {
match create_result { match create_result {
Ok(id) => { Ok(id) => {
info!("Created action '{}' (ID: {})", action_ref, id); info!("Created action '{}' (ID: {})", action_ref, id);
loaded_refs.push(action_ref);
result.actions_loaded += 1; result.actions_loaded += 1;
} }
Err(e) => { Err(e) => {
@@ -611,10 +753,11 @@ impl<'a> PackComponentLoader<'a> {
if let sqlx::Error::Database(ref db_err) = e { if let sqlx::Error::Database(ref db_err) = e {
if db_err.is_unique_violation() { if db_err.is_unique_violation() {
info!( info!(
"Action '{}' already exists (concurrent creation), skipping", "Action '{}' already exists (concurrent creation), treating as update",
action_ref action_ref
); );
result.actions_skipped += 1; loaded_refs.push(action_ref);
result.actions_updated += 1;
continue; continue;
} }
} }
@@ -625,21 +768,24 @@ impl<'a> PackComponentLoader<'a> {
} }
} }
Ok(()) Ok(loaded_refs)
} }
/// Load sensor definitions from `pack_dir/sensors/*.yaml`. /// Load sensor definitions from `pack_dir/sensors/*.yaml`.
///
/// Returns the list of loaded sensor refs for cleanup.
async fn load_sensors( async fn load_sensors(
&self, &self,
pack_dir: &Path, pack_dir: &Path,
trigger_ids: &HashMap<String, Id>, trigger_ids: &HashMap<String, Id>,
result: &mut PackLoadResult, result: &mut PackLoadResult,
) -> Result<()> { ) -> Result<Vec<String>> {
let sensors_dir = pack_dir.join("sensors"); let sensors_dir = pack_dir.join("sensors");
let mut loaded_refs = Vec::new();
if !sensors_dir.exists() { if !sensors_dir.exists() {
info!("No sensors directory found for pack '{}'", self.pack_ref); info!("No sensors directory found for pack '{}'", self.pack_ref);
return Ok(()); return Ok(loaded_refs);
} }
let yaml_files = read_yaml_files(&sensors_dir)?; let yaml_files = read_yaml_files(&sensors_dir)?;
@@ -758,8 +904,6 @@ impl<'a> PackComponentLoader<'a> {
// Upsert: update existing sensors so re-registration corrects // Upsert: update existing sensors so re-registration corrects
// stale metadata (especially runtime assignments). // stale metadata (especially runtime assignments).
if let Some(existing) = SensorRepository::find_by_ref(self.pool, &sensor_ref).await? { if let Some(existing) = SensorRepository::find_by_ref(self.pool, &sensor_ref).await? {
use crate::repositories::trigger::UpdateSensorInput;
let update_input = UpdateSensorInput { let update_input = UpdateSensorInput {
label: Some(label), label: Some(label),
description: Some(description), description: Some(description),
@@ -780,7 +924,7 @@ impl<'a> PackComponentLoader<'a> {
"Updated sensor '{}' (ID: {}, runtime: {} → {})", "Updated sensor '{}' (ID: {}, runtime: {} → {})",
sensor_ref, existing.id, existing.runtime_ref, sensor_runtime_ref sensor_ref, existing.id, existing.runtime_ref, sensor_runtime_ref
); );
result.sensors_loaded += 1; result.sensors_updated += 1;
} }
Err(e) => { Err(e) => {
let msg = format!("Failed to update sensor '{}': {}", sensor_ref, e); let msg = format!("Failed to update sensor '{}': {}", sensor_ref, e);
@@ -788,6 +932,7 @@ impl<'a> PackComponentLoader<'a> {
result.warnings.push(msg); result.warnings.push(msg);
} }
} }
loaded_refs.push(sensor_ref);
continue; continue;
} }
@@ -811,6 +956,7 @@ impl<'a> PackComponentLoader<'a> {
match SensorRepository::create(self.pool, input).await { match SensorRepository::create(self.pool, input).await {
Ok(sensor) => { Ok(sensor) => {
info!("Created sensor '{}' (ID: {})", sensor_ref, sensor.id); info!("Created sensor '{}' (ID: {})", sensor_ref, sensor.id);
loaded_refs.push(sensor_ref);
result.sensors_loaded += 1; result.sensors_loaded += 1;
} }
Err(e) => { Err(e) => {
@@ -821,7 +967,7 @@ impl<'a> PackComponentLoader<'a> {
} }
} }
Ok(()) Ok(loaded_refs)
} }
/// Resolve a runtime ID from a runner type string (e.g., "shell", "python", "native"). /// Resolve a runtime ID from a runner type string (e.g., "shell", "python", "native").
@@ -917,11 +1063,116 @@ impl<'a> PackComponentLoader<'a> {
} }
} }
} }
/// Remove entities that belong to this pack but whose refs are no longer
/// present in the pack's YAML files.
///
/// This handles the case where an action/trigger/sensor/runtime was removed
/// from the pack between versions. Ad-hoc (user-created) entities are never
/// removed.
async fn cleanup_removed_entities(
&self,
runtime_refs: &[String],
trigger_refs: &[String],
action_refs: &[String],
sensor_refs: &[String],
result: &mut PackLoadResult,
) {
// Clean up sensors first (they depend on triggers/runtimes)
match SensorRepository::delete_by_pack_excluding(self.pool, self.pack_id, sensor_refs).await
{
Ok(count) => {
if count > 0 {
info!(
"Removed {} stale sensor(s) from pack '{}'",
count, self.pack_ref
);
result.removed += count as usize;
}
}
Err(e) => {
warn!(
"Failed to clean up stale sensors for pack '{}': {}",
self.pack_ref, e
);
}
}
// Clean up actions (ad-hoc preserved)
match ActionRepository::delete_non_adhoc_by_pack_excluding(
self.pool,
self.pack_id,
action_refs,
)
.await
{
Ok(count) => {
if count > 0 {
info!(
"Removed {} stale action(s) from pack '{}'",
count, self.pack_ref
);
result.removed += count as usize;
}
}
Err(e) => {
warn!(
"Failed to clean up stale actions for pack '{}': {}",
self.pack_ref, e
);
}
}
// Clean up triggers (ad-hoc preserved)
match TriggerRepository::delete_non_adhoc_by_pack_excluding(
self.pool,
self.pack_id,
trigger_refs,
)
.await
{
Ok(count) => {
if count > 0 {
info!(
"Removed {} stale trigger(s) from pack '{}'",
count, self.pack_ref
);
result.removed += count as usize;
}
}
Err(e) => {
warn!(
"Failed to clean up stale triggers for pack '{}': {}",
self.pack_ref, e
);
}
}
// Clean up runtimes last (actions/sensors may reference them)
match RuntimeRepository::delete_by_pack_excluding(self.pool, self.pack_id, runtime_refs)
.await
{
Ok(count) => {
if count > 0 {
info!(
"Removed {} stale runtime(s) from pack '{}'",
count, self.pack_ref
);
result.removed += count as usize;
}
}
Err(e) => {
warn!(
"Failed to clean up stale runtimes for pack '{}': {}",
self.pack_ref, e
);
}
}
}
} }
/// Read all `.yaml` and `.yml` files from a directory, sorted by filename. /// Read all YAML files from a directory, returning `(filename, content)` pairs
/// /// sorted by filename for deterministic ordering.
/// Returns a Vec of (filename, content) pairs.
fn read_yaml_files(dir: &Path) -> Result<Vec<(String, String)>> { fn read_yaml_files(dir: &Path) -> Result<Vec<(String, String)>> {
let mut files = Vec::new(); let mut files = Vec::new();

197
crates/common/src/repositories/action.rs
View File

@@ -8,6 +8,11 @@ use sqlx::{Executor, Postgres, QueryBuilder};
use super::{Create, Delete, FindById, FindByRef, List, Repository, Update}; use super::{Create, Delete, FindById, FindByRef, List, Repository, Update};
/// Columns selected in all Action queries. Must match the `Action` model's `FromRow` fields.
pub const ACTION_COLUMNS: &str = "id, ref, pack, pack_ref, label, description, entrypoint, \
runtime, runtime_version_constraint, param_schema, out_schema, workflow_def, is_adhoc, \
parameter_delivery, parameter_format, output_format, created, updated";
/// Filters for [`ActionRepository::list_search`]. /// Filters for [`ActionRepository::list_search`].
/// ///
/// All fields are optional and combinable (AND). Pagination is always applied. /// All fields are optional and combinable (AND). Pagination is always applied.
@@ -65,6 +70,9 @@ pub struct UpdateActionInput {
pub runtime_version_constraint: Option<Option<String>>, pub runtime_version_constraint: Option<Option<String>>,
pub param_schema: Option<JsonSchema>, pub param_schema: Option<JsonSchema>,
pub out_schema: Option<JsonSchema>, pub out_schema: Option<JsonSchema>,
pub parameter_delivery: Option<String>,
pub parameter_format: Option<String>,
pub output_format: Option<String>,
} }
#[async_trait::async_trait] #[async_trait::async_trait]
@@ -73,15 +81,10 @@ impl FindById for ActionRepository {
where where
E: Executor<'e, Database = Postgres> + 'e, E: Executor<'e, Database = Postgres> + 'e,
{ {
let action = sqlx::query_as::<_, Action>( let action = sqlx::query_as::<_, Action>(&format!(
r#" "SELECT {} FROM action WHERE id = $1",
SELECT id, ref, pack, pack_ref, label, description, entrypoint, ACTION_COLUMNS
runtime, runtime_version_constraint, ))
param_schema, out_schema, workflow_def, is_adhoc, created, updated
FROM action
WHERE id = $1
"#,
)
.bind(id) .bind(id)
.fetch_optional(executor) .fetch_optional(executor)
.await?; .await?;
@@ -96,15 +99,10 @@ impl FindByRef for ActionRepository {
where where
E: Executor<'e, Database = Postgres> + 'e, E: Executor<'e, Database = Postgres> + 'e,
{ {
let action = sqlx::query_as::<_, Action>( let action = sqlx::query_as::<_, Action>(&format!(
r#" "SELECT {} FROM action WHERE ref = $1",
SELECT id, ref, pack, pack_ref, label, description, entrypoint, ACTION_COLUMNS
runtime, runtime_version_constraint, ))
param_schema, out_schema, workflow_def, is_adhoc, created, updated
FROM action
WHERE ref = $1
"#,
)
.bind(ref_str) .bind(ref_str)
.fetch_optional(executor) .fetch_optional(executor)
.await?; .await?;
@@ -119,15 +117,10 @@ impl List for ActionRepository {
where where
E: Executor<'e, Database = Postgres> + 'e, E: Executor<'e, Database = Postgres> + 'e,
{ {
let actions = sqlx::query_as::<_, Action>( let actions = sqlx::query_as::<_, Action>(&format!(
r#" "SELECT {} FROM action ORDER BY ref ASC",
SELECT id, ref, pack, pack_ref, label, description, entrypoint, ACTION_COLUMNS
runtime, runtime_version_constraint, ))
param_schema, out_schema, workflow_def, is_adhoc, created, updated
FROM action
ORDER BY ref ASC
"#,
)
.fetch_all(executor) .fetch_all(executor)
.await?; .await?;
@@ -155,16 +148,15 @@ impl Create for ActionRepository {
} }
// Try to insert - database will enforce uniqueness constraint // Try to insert - database will enforce uniqueness constraint
let action = sqlx::query_as::<_, Action>( let action = sqlx::query_as::<_, Action>(&format!(
r#" r#"
INSERT INTO action (ref, pack, pack_ref, label, description, entrypoint, INSERT INTO action (ref, pack, pack_ref, label, description, entrypoint,
runtime, runtime_version_constraint, param_schema, out_schema, is_adhoc) runtime, runtime_version_constraint, param_schema, out_schema, is_adhoc)
VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11) VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11)
RETURNING id, ref, pack, pack_ref, label, description, entrypoint, RETURNING {}
runtime, runtime_version_constraint,
param_schema, out_schema, workflow_def, is_adhoc, created, updated
"#, "#,
) ACTION_COLUMNS
))
.bind(&input.r#ref) .bind(&input.r#ref)
.bind(input.pack) .bind(input.pack)
.bind(&input.pack_ref) .bind(&input.pack_ref)
@@ -267,6 +259,33 @@ impl Update for ActionRepository {
has_updates = true; has_updates = true;
} }
if let Some(parameter_delivery) = &input.parameter_delivery {
if has_updates {
query.push(", ");
}
query.push("parameter_delivery = ");
query.push_bind(parameter_delivery);
has_updates = true;
}
if let Some(parameter_format) = &input.parameter_format {
if has_updates {
query.push(", ");
}
query.push("parameter_format = ");
query.push_bind(parameter_format);
has_updates = true;
}
if let Some(output_format) = &input.output_format {
if has_updates {
query.push(", ");
}
query.push("output_format = ");
query.push_bind(output_format);
has_updates = true;
}
if !has_updates { if !has_updates {
// No updates requested, fetch and return existing action // No updates requested, fetch and return existing action
return Self::find_by_id(executor, id) return Self::find_by_id(executor, id)
@@ -276,7 +295,7 @@ impl Update for ActionRepository {
query.push(", updated = NOW() WHERE id = "); query.push(", updated = NOW() WHERE id = ");
query.push_bind(id); query.push_bind(id);
query.push(" RETURNING id, ref, pack, pack_ref, label, description, entrypoint, runtime, runtime_version_constraint, param_schema, out_schema, workflow_def, is_adhoc, created, updated"); query.push(&format!(" RETURNING {}", ACTION_COLUMNS));
let action = query let action = query
.build_query_as::<Action>() .build_query_as::<Action>()
@@ -317,10 +336,8 @@ impl ActionRepository {
where where
E: Executor<'e, Database = Postgres> + Copy + 'e, E: Executor<'e, Database = Postgres> + Copy + 'e,
{ {
let select_cols = "id, ref, pack, pack_ref, label, description, entrypoint, runtime, runtime_version_constraint, param_schema, out_schema, workflow_def, is_adhoc, created, updated";
let mut qb: QueryBuilder<'_, Postgres> = let mut qb: QueryBuilder<'_, Postgres> =
QueryBuilder::new(format!("SELECT {select_cols} FROM action")); QueryBuilder::new(format!("SELECT {} FROM action", ACTION_COLUMNS));
let mut count_qb: QueryBuilder<'_, Postgres> = let mut count_qb: QueryBuilder<'_, Postgres> =
QueryBuilder::new("SELECT COUNT(*) FROM action"); QueryBuilder::new("SELECT COUNT(*) FROM action");
@@ -398,16 +415,10 @@ impl ActionRepository {
where where
E: Executor<'e, Database = Postgres> + 'e, E: Executor<'e, Database = Postgres> + 'e,
{ {
let actions = sqlx::query_as::<_, Action>( let actions = sqlx::query_as::<_, Action>(&format!(
r#" "SELECT {} FROM action WHERE pack = $1 ORDER BY ref ASC",
SELECT id, ref, pack, pack_ref, label, description, entrypoint, ACTION_COLUMNS
runtime, runtime_version_constraint, ))
param_schema, out_schema, workflow_def, is_adhoc, created, updated
FROM action
WHERE pack = $1
ORDER BY ref ASC
"#,
)
.bind(pack_id) .bind(pack_id)
.fetch_all(executor) .fetch_all(executor)
.await?; .await?;
@@ -420,16 +431,10 @@ impl ActionRepository {
where where
E: Executor<'e, Database = Postgres> + 'e, E: Executor<'e, Database = Postgres> + 'e,
{ {
let actions = sqlx::query_as::<_, Action>( let actions = sqlx::query_as::<_, Action>(&format!(
r#" "SELECT {} FROM action WHERE runtime = $1 ORDER BY ref ASC",
SELECT id, ref, pack, pack_ref, label, description, entrypoint, ACTION_COLUMNS
runtime, runtime_version_constraint, ))
param_schema, out_schema, workflow_def, is_adhoc, created, updated
FROM action
WHERE runtime = $1
ORDER BY ref ASC
"#,
)
.bind(runtime_id) .bind(runtime_id)
.fetch_all(executor) .fetch_all(executor)
.await?; .await?;
@@ -443,16 +448,10 @@ impl ActionRepository {
E: Executor<'e, Database = Postgres> + 'e, E: Executor<'e, Database = Postgres> + 'e,
{ {
let search_pattern = format!("%{}%", query.to_lowercase()); let search_pattern = format!("%{}%", query.to_lowercase());
let actions = sqlx::query_as::<_, Action>( let actions = sqlx::query_as::<_, Action>(&format!(
r#" "SELECT {} FROM action WHERE LOWER(ref) LIKE $1 OR LOWER(label) LIKE $1 OR LOWER(description) LIKE $1 ORDER BY ref ASC",
SELECT id, ref, pack, pack_ref, label, description, entrypoint, ACTION_COLUMNS
runtime, runtime_version_constraint, ))
param_schema, out_schema, workflow_def, is_adhoc, created, updated
FROM action
WHERE LOWER(ref) LIKE $1 OR LOWER(label) LIKE $1 OR LOWER(description) LIKE $1
ORDER BY ref ASC
"#,
)
.bind(&search_pattern) .bind(&search_pattern)
.fetch_all(executor) .fetch_all(executor)
.await?; .await?;
@@ -465,16 +464,10 @@ impl ActionRepository {
where where
E: Executor<'e, Database = Postgres> + 'e, E: Executor<'e, Database = Postgres> + 'e,
{ {
let actions = sqlx::query_as::<_, Action>( let actions = sqlx::query_as::<_, Action>(&format!(
r#" "SELECT {} FROM action WHERE workflow_def IS NOT NULL ORDER BY ref ASC",
SELECT id, ref, pack, pack_ref, label, description, entrypoint, ACTION_COLUMNS
runtime, runtime_version_constraint, ))
param_schema, out_schema, workflow_def, is_adhoc, created, updated
FROM action
WHERE workflow_def IS NOT NULL
ORDER BY ref ASC
"#,
)
.fetch_all(executor) .fetch_all(executor)
.await?; .await?;
@@ -489,15 +482,10 @@ impl ActionRepository {
where where
E: Executor<'e, Database = Postgres> + 'e, E: Executor<'e, Database = Postgres> + 'e,
{ {
let action = sqlx::query_as::<_, Action>( let action = sqlx::query_as::<_, Action>(&format!(
r#" "SELECT {} FROM action WHERE workflow_def = $1",
SELECT id, ref, pack, pack_ref, label, description, entrypoint, ACTION_COLUMNS
runtime, runtime_version_constraint, ))
param_schema, out_schema, workflow_def, is_adhoc, created, updated
FROM action
WHERE workflow_def = $1
"#,
)
.bind(workflow_def_id) .bind(workflow_def_id)
.fetch_optional(executor) .fetch_optional(executor)
.await?; .await?;
@@ -505,6 +493,36 @@ impl ActionRepository {
Ok(action) Ok(action)
} }
/// Delete non-adhoc actions belonging to a pack whose refs are NOT in the given set.
///
/// Used during pack reinstallation to clean up actions that were removed
/// from the pack's YAML files. Ad-hoc (user-created) actions are preserved.
pub async fn delete_non_adhoc_by_pack_excluding<'e, E>(
executor: E,
pack_id: Id,
keep_refs: &[String],
) -> Result<u64>
where
E: Executor<'e, Database = Postgres> + 'e,
{
let result = if keep_refs.is_empty() {
sqlx::query("DELETE FROM action WHERE pack = $1 AND is_adhoc = false")
.bind(pack_id)
.execute(executor)
.await?
} else {
sqlx::query(
"DELETE FROM action WHERE pack = $1 AND is_adhoc = false AND ref != ALL($2)",
)
.bind(pack_id)
.bind(keep_refs)
.execute(executor)
.await?
};
Ok(result.rows_affected())
}
/// Link an action to a workflow definition /// Link an action to a workflow definition
pub async fn link_workflow_def<'e, E>( pub async fn link_workflow_def<'e, E>(
executor: E, executor: E,
@@ -514,16 +532,15 @@ impl ActionRepository {
where where
E: Executor<'e, Database = Postgres> + 'e, E: Executor<'e, Database = Postgres> + 'e,
{ {
let action = sqlx::query_as::<_, Action>( let action = sqlx::query_as::<_, Action>(&format!(
r#" r#"
UPDATE action UPDATE action
SET workflow_def = $2, updated = NOW() SET workflow_def = $2, updated = NOW()
WHERE id = $1 WHERE id = $1
RETURNING id, ref, pack, pack_ref, label, description, entrypoint, RETURNING {}
runtime, runtime_version_constraint,
param_schema, out_schema, workflow_def, is_adhoc, created, updated
"#, "#,
) ACTION_COLUMNS
))
.bind(action_id) .bind(action_id)
.bind(workflow_def_id) .bind(workflow_def_id)
.fetch_one(executor) .fetch_one(executor)

10
crates/common/src/repositories/artifact.rs
View File

@@ -52,6 +52,7 @@ pub struct UpdateArtifactInput {
pub description: Option<String>, pub description: Option<String>,
pub content_type: Option<String>, pub content_type: Option<String>,
pub size_bytes: Option<i64>, pub size_bytes: Option<i64>,
pub execution: Option<Option<i64>>,
pub data: Option<serde_json::Value>, pub data: Option<serde_json::Value>,
} }
@@ -189,6 +190,15 @@ impl Update for ArtifactRepository {
push_field!(&input.description, "description"); push_field!(&input.description, "description");
push_field!(&input.content_type, "content_type"); push_field!(&input.content_type, "content_type");
push_field!(input.size_bytes, "size_bytes"); push_field!(input.size_bytes, "size_bytes");
// execution is Option<Option<i64>> — outer Option = "was field provided?",
// inner Option = nullable column value
if let Some(exec_val) = input.execution {
if has_updates {
query.push(", ");
}
query.push("execution = ").push_bind(exec_val);
has_updates = true;
}
push_field!(&input.data, "data"); push_field!(&input.data, "data");
if !has_updates { if !has_updates {

28
crates/common/src/repositories/runtime.rs
View File

@@ -284,6 +284,34 @@ impl RuntimeRepository {
Ok(runtime) Ok(runtime)
} }
/// Delete runtimes belonging to a pack whose refs are NOT in the given set.
///
/// Used during pack reinstallation to clean up runtimes that were removed
/// from the pack's YAML files. Associated runtime_version rows are
/// cascade-deleted by the FK constraint.
pub async fn delete_by_pack_excluding<'e, E>(
executor: E,
pack_id: Id,
keep_refs: &[String],
) -> Result<u64>
where
E: Executor<'e, Database = Postgres> + 'e,
{
let result = if keep_refs.is_empty() {
sqlx::query("DELETE FROM runtime WHERE pack = $1")
.bind(pack_id)
.execute(executor)
.await?
} else {
sqlx::query("DELETE FROM runtime WHERE pack = $1 AND ref != ALL($2)")
.bind(pack_id)
.bind(keep_refs)
.execute(executor)
.await?
};
Ok(result.rows_affected())
}
} }
// ============================================================================ // ============================================================================

58
crates/common/src/repositories/trigger.rs
View File

@@ -301,6 +301,36 @@ impl Delete for TriggerRepository {
} }
impl TriggerRepository { impl TriggerRepository {
/// Delete non-adhoc triggers belonging to a pack whose refs are NOT in the given set.
///
/// Used during pack reinstallation to clean up triggers that were removed
/// from the pack's YAML files. Ad-hoc (user-created) triggers are preserved.
pub async fn delete_non_adhoc_by_pack_excluding<'e, E>(
executor: E,
pack_id: Id,
keep_refs: &[String],
) -> Result<u64>
where
E: Executor<'e, Database = Postgres> + 'e,
{
let result = if keep_refs.is_empty() {
sqlx::query("DELETE FROM trigger WHERE pack = $1 AND is_adhoc = false")
.bind(pack_id)
.execute(executor)
.await?
} else {
sqlx::query(
"DELETE FROM trigger WHERE pack = $1 AND is_adhoc = false AND ref != ALL($2)",
)
.bind(pack_id)
.bind(keep_refs)
.execute(executor)
.await?
};
Ok(result.rows_affected())
}
/// Search triggers with all filters pushed into SQL. /// Search triggers with all filters pushed into SQL.
/// ///
/// All filter fields are combinable (AND). Pagination is server-side. /// All filter fields are combinable (AND). Pagination is server-side.
@@ -907,6 +937,34 @@ impl Delete for SensorRepository {
} }
impl SensorRepository { impl SensorRepository {
/// Delete non-adhoc sensors belonging to a pack whose refs are NOT in the given set.
///
/// Used during pack reinstallation to clean up sensors that were removed
/// from the pack's YAML files.
pub async fn delete_by_pack_excluding<'e, E>(
executor: E,
pack_id: Id,
keep_refs: &[String],
) -> Result<u64>
where
E: Executor<'e, Database = Postgres> + 'e,
{
let result = if keep_refs.is_empty() {
sqlx::query("DELETE FROM sensor WHERE pack = $1")
.bind(pack_id)
.execute(executor)
.await?
} else {
sqlx::query("DELETE FROM sensor WHERE pack = $1 AND ref != ALL($2)")
.bind(pack_id)
.bind(keep_refs)
.execute(executor)
.await?
};
Ok(result.rows_affected())
}
/// Search sensors with all filters pushed into SQL. /// Search sensors with all filters pushed into SQL.
/// ///
/// All filter fields are combinable (AND). Pagination is server-side. /// All filter fields are combinable (AND). Pagination is server-side.

3
crates/common/src/workflow/registrar.rs
View File

@@ -257,6 +257,9 @@ impl WorkflowRegistrar {
runtime_version_constraint: None, runtime_version_constraint: None,
param_schema: workflow.parameters.clone(), param_schema: workflow.parameters.clone(),
out_schema: workflow.output.clone(), out_schema: workflow.output.clone(),
parameter_delivery: None,
parameter_format: None,
output_format: None,
}; };
ActionRepository::update(&self.pool, action.id, update_input).await?; ActionRepository::update(&self.pool, action.id, update_input).await?;

6
crates/common/tests/action_repository_tests.rs
View File

@@ -196,11 +196,7 @@ async fn test_update_action() {
let update = UpdateActionInput { let update = UpdateActionInput {
label: Some("Updated Label".to_string()), label: Some("Updated Label".to_string()),
description: Some("Updated description".to_string()), description: Some("Updated description".to_string()),
entrypoint: None, ..Default::default()
runtime: None,
runtime_version_constraint: None,
param_schema: None,
out_schema: None,
}; };
let updated = ActionRepository::update(&pool, action.id, update) let updated = ActionRepository::update(&pool, action.id, update)

1
crates/common/tests/repository_artifact_tests.rs
View File

@@ -263,6 +263,7 @@ async fn test_update_artifact_all_fields() {
content_type: Some("image/png".to_string()), content_type: Some("image/png".to_string()),
size_bytes: Some(12345), size_bytes: Some(12345),
data: Some(serde_json::json!({"key": "value"})), data: Some(serde_json::json!({"key": "value"})),
execution: None,
}; };
let updated = ArtifactRepository::update(&pool, created.id, update_input.clone()) let updated = ArtifactRepository::update(&pool, created.id, update_input.clone())

3
crates/executor/src/workflow/registrar.rs
View File

@@ -259,6 +259,9 @@ impl WorkflowRegistrar {
runtime_version_constraint: None, runtime_version_constraint: None,
param_schema: workflow.parameters.clone(), param_schema: workflow.parameters.clone(),
out_schema: workflow.output.clone(), out_schema: workflow.output.clone(),
parameter_delivery: None,
parameter_format: None,
output_format: None,
}; };
ActionRepository::update(&self.pool, action.id, update_input).await?; ActionRepository::update(&self.pool, action.id, update_input).await?;

2
web/src/components/layout/MainLayout.tsx
View File

@@ -16,8 +16,6 @@ import {
SquareAsterisk, SquareAsterisk,
KeyRound, KeyRound,
Home, Home,
Paperclip,
FolderOpenDot,
FolderArchive, FolderArchive,
} from "lucide-react"; } from "lucide-react";