fixing lints

.gitignore

@@ -78,3 +78,4 @@ docker-compose.override.yml
 *.pid
 
 packs.examples/
+codex/

.semgrepignore

@@ -2,6 +2,5 @@ target/
 web/dist/
 web/node_modules/
 web/src/api/
-packs/
 packs.dev/
 packs.external/

crates/api/src/routes/packs.rs

@@ -29,8 +29,8 @@ use crate::{
         pack::{
             BuildPackEnvsRequest, BuildPackEnvsResponse, CreatePackRequest, DownloadPacksRequest,
             DownloadPacksResponse, GetPackDependenciesRequest, GetPackDependenciesResponse,
-            InstallPackRequest, PackInstallResponse, PackResponse, PackSummary,
+            InstallPackRequest, PackDescriptionPatch, PackInstallResponse, PackResponse,
-            PackDescriptionPatch, PackWorkflowSyncResponse, PackWorkflowValidationResponse,
+            PackSummary, PackWorkflowSyncResponse, PackWorkflowValidationResponse,
             RegisterPackRequest, RegisterPacksRequest, RegisterPacksResponse, UpdatePackRequest,
             WorkflowSyncResult,
         },

crates/api/src/routes/triggers.rs

@@ -26,8 +26,8 @@ use crate::{
         common::{PaginatedResponse, PaginationParams},
         trigger::{
             CreateSensorRequest, CreateTriggerRequest, SensorJsonPatch, SensorResponse,
-            SensorSummary, TriggerJsonPatch, TriggerResponse, TriggerStringPatch,
+            SensorSummary, TriggerJsonPatch, TriggerResponse, TriggerStringPatch, TriggerSummary,
-            TriggerSummary, UpdateSensorRequest, UpdateTriggerRequest,
+            UpdateSensorRequest, UpdateTriggerRequest,
         },
         ApiResponse, SuccessResponse,
     },

web/eslint.config.js

@@ -6,7 +6,7 @@ import tseslint from 'typescript-eslint'
 import { defineConfig, globalIgnores } from 'eslint/config'
 
 export default defineConfig([
-  globalIgnores(['dist']),
+  globalIgnores(['dist', 'src/api']),
   {
     files: ['**/*.{ts,tsx}'],
     extends: [

web/src/components/forms/RuntimeForm.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useMemo, useState } from "react";
+import { useMemo, useState } from "react";
 import { useNavigate } from "react-router-dom";
 import { usePacks } from "@/hooks/usePacks";
 import { useCreateRuntime, useUpdateRuntime } from "@/hooks/useRuntimes";
@@ -15,7 +15,15 @@ interface RuntimeFormProps {
   onCancel?: () => void;
 }
 
-type JsonObject = Record<string, any>;
+type JsonValue =
+  | string
+  | number
+  | boolean
+  | null
+  | { [key: string]: JsonValue }
+  | JsonValue[];
+type JsonObject = { [key: string]: JsonValue };
+type NonNullJsonValue = Exclude<JsonValue, null>;
 
 function prettyJson(value: unknown): string {
   return JSON.stringify(value ?? {}, null, 2);
@@ -40,7 +48,11 @@ function validateObjectJson(label: string, raw: string): JsonObject {
   }
 }
 
-function validateJsonValue(label: string, raw: string, required = true): any {
+function validateJsonValue(
+  label: string,
+  raw: string,
+  required = true,
+): NonNullJsonValue | null {
   if (!raw.trim()) {
     if (required) {
       throw new Error(`${label} is required`);
@@ -49,7 +61,7 @@ function validateJsonValue(label: string, raw: string, required = true): any {
   }
 
   try {
-    return JSON.parse(raw) as any;
+    return JSON.parse(raw) as NonNullJsonValue;
   } catch {
     throw new Error(`${label} must be valid JSON`);
   }
@@ -66,31 +78,23 @@ export default function RuntimeForm({
   const createRuntime = useCreateRuntime();
   const updateRuntime = useUpdateRuntime();
 
-  const [ref, setRef] = useState("");
+  const [ref, setRef] = useState(() => initialData?.ref ?? "");
-  const [packRef, setPackRef] = useState("");
+  const [packRef, setPackRef] = useState(() => initialData?.pack_ref ?? "");
-  const [name, setName] = useState("");
+  const [name, setName] = useState(() => initialData?.name ?? "");
-  const [description, setDescription] = useState("");
+  const [description, setDescription] = useState(
-  const [distributions, setDistributions] = useState("{}");
+    () => initialData?.description ?? "",
-  const [installation, setInstallation] = useState("");
+  );
-  const [executionConfig, setExecutionConfig] = useState("{}");
+  const [distributions, setDistributions] = useState(() =>
+    prettyJson(initialData?.distributions ?? {}),
+  );
+  const [installation, setInstallation] = useState(() =>
+    initialData?.installation == null ? "" : prettyJson(initialData.installation),
+  );
+  const [executionConfig, setExecutionConfig] = useState(() =>
+    prettyJson(initialData?.execution_config ?? {}),
+  );
   const [errors, setErrors] = useState<Record<string, string>>({});
 
-  useEffect(() => {
-    if (!initialData) {
-      return;
-    }
-
-    setRef(initialData.ref);
-    setPackRef(initialData.pack_ref ?? "");
-    setName(initialData.name);
-    setDescription(initialData.description ?? "");
-    setDistributions(prettyJson(initialData.distributions));
-    setInstallation(
-      initialData.installation == null ? "" : prettyJson(initialData.installation),
-    );
-    setExecutionConfig(prettyJson(initialData.execution_config));
-  }, [initialData]);
-
   const canEditRef = !isEditing;
   const isSubmitting = createRuntime.isPending || updateRuntime.isPending;
   const selectedPackExists =
@@ -113,7 +117,7 @@ export default function RuntimeForm({
 
     let parsedDistributions: JsonObject | undefined;
     let parsedExecutionConfig: JsonObject | undefined;
-    let parsedInstallation: any = null;
+    let parsedInstallation: NonNullJsonValue | null = null;
 
     try {
       parsedDistributions = validateObjectJson("Distributions", distributions);
@@ -146,6 +150,11 @@ export default function RuntimeForm({
 
     try {
       if (isEditing && initialData) {
+        const installationPatch =
+          installation.trim().length > 0 && parsedInstallation !== null
+            ? { op: NullableJsonPatch.op.SET, value: parsedInstallation }
+            : null;
+
         await updateRuntime.mutateAsync({
           ref: initialData.ref,
           data: {
@@ -154,10 +163,7 @@ export default function RuntimeForm({
               : null,
             name: name.trim(),
             distributions: parsedDistributions,
-            installation:
+            installation: installationPatch,
-              installation.trim().length > 0
-                ? { op: NullableJsonPatch.op.SET, value: parsedInstallation }
-                : null,
             execution_config: parsedExecutionConfig,
           },
         });

web/src/pages/runtimes/RuntimesPage.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useMemo, useState } from "react";
+import { useMemo, useState } from "react";
 import { Link, useNavigate, useParams } from "react-router-dom";
 import { Code2, Pencil, Plus, Search, Trash2, X } from "lucide-react";
 import type { RuntimeSummary } from "@/api";
@@ -144,7 +144,7 @@ export default function RuntimesPage() {
         {ref === "new" ? (
           <RuntimeForm />
         ) : ref ? (
-          <RuntimeDetail runtimeRef={ref} />
+          <RuntimeDetail key={ref} runtimeRef={ref} />
         ) : (
           <div className="flex items-center justify-center h-full">
             <div className="text-center text-gray-500">
@@ -169,10 +169,6 @@ function RuntimeDetail({ runtimeRef }: { runtimeRef: string }) {
   const deleteRuntime = useDeleteRuntime();
   const [isEditing, setIsEditing] = useState(false);
 
-  useEffect(() => {
-    setIsEditing(false);
-  }, [runtimeRef]);
-
   if (isLoading) {
     return (
       <div className="p-6">