making linters happy

crates/common/tests/execution_repository_tests.rs

@@ -781,7 +781,7 @@ async fn test_find_executions_by_enforcement() {
             config: None,
             env_vars: None,
             parent: None,
-            enforcement: if i == 2 { None } else { None }, // Can't reference non-existent enforcement
+            enforcement: None, // Can't reference non-existent enforcement
             executor: None,
             status: ExecutionStatus::Requested,
             result: None,

crates/common/tests/key_repository_tests.rs

@@ -35,7 +35,7 @@ async fn test_create_key_system_owner() {
     assert_eq!(key.owner_pack, None);
     assert_eq!(key.owner_action, None);
     assert_eq!(key.owner_sensor, None);
-    assert_eq!(key.encrypted, false);
+    assert!(!key.encrypted);
     assert_eq!(key.value, "test_value");
     assert!(key.created.timestamp() > 0);
     assert!(key.updated.timestamp() > 0);
@@ -52,7 +52,7 @@ async fn test_create_key_system_encrypted() {
         .await
         .unwrap();
 
-    assert_eq!(key.encrypted, true);
+    assert!(key.encrypted);
     assert_eq!(key.encryption_key_hash, Some("sha256:abc123".to_string()));
 }
 
@@ -427,7 +427,7 @@ async fn test_update_encrypted_status() {
         .await
         .unwrap();
 
-    assert_eq!(key.encrypted, false);
+    assert!(!key.encrypted);
 
     let input = UpdateKeyInput {
         encrypted: Some(true),
@@ -438,7 +438,7 @@ async fn test_update_encrypted_status() {
 
     let updated = KeyRepository::update(&pool, key.id, input).await.unwrap();
 
-    assert_eq!(updated.encrypted, true);
+    assert!(updated.encrypted);
     assert_eq!(
         updated.encryption_key_hash,
         Some("sha256:xyz789".to_string())
@@ -468,7 +468,7 @@ async fn test_update_multiple_fields() {
 
     assert_eq!(updated.name, new_name);
     assert_eq!(updated.value, "updated_value");
-    assert_eq!(updated.encrypted, true);
+    assert!(updated.encrypted);
     assert_eq!(updated.encryption_key_hash, Some("hash123".to_string()));
 }
 
@@ -768,10 +768,10 @@ async fn test_key_encrypted_flag() {
         .await
         .unwrap();
 
-    assert_eq!(plain_key.encrypted, false);
+    assert!(!plain_key.encrypted);
     assert_eq!(plain_key.encryption_key_hash, None);
 
-    assert_eq!(encrypted_key.encrypted, true);
+    assert!(encrypted_key.encrypted);
     assert_eq!(
         encrypted_key.encryption_key_hash,
         Some("sha256:abc".to_string())
@@ -788,7 +788,7 @@ async fn test_update_encryption_status() {
         .await
         .unwrap();
 
-    assert_eq!(key.encrypted, false);
+    assert!(!key.encrypted);
 
     // Encrypt it
     let input = UpdateKeyInput {
@@ -800,7 +800,7 @@ async fn test_update_encryption_status() {
 
     let encrypted = KeyRepository::update(&pool, key.id, input).await.unwrap();
 
-    assert_eq!(encrypted.encrypted, true);
+    assert!(encrypted.encrypted);
     assert_eq!(
         encrypted.encryption_key_hash,
         Some("sha256:newkey".to_string())
@@ -817,7 +817,7 @@ async fn test_update_encryption_status() {
 
     let decrypted = KeyRepository::update(&pool, key.id, input).await.unwrap();
 
-    assert_eq!(decrypted.encrypted, false);
+    assert!(!decrypted.encrypted);
     assert_eq!(decrypted.value, "plain_value");
 }
 

crates/common/tests/repository_worker_tests.rs

@@ -892,7 +892,7 @@ async fn test_port_range() {
 
         let worker = WorkerRepository::create(&pool, input)
             .await
-            .expect(&format!("Failed to create worker with port {}", port));
+            .unwrap_or_else(|_| panic!("Failed to create worker with port {}", port));
 
         assert_eq!(worker.port, Some(port));
     }

crates/common/tests/rule_repository_tests.rs

@@ -74,7 +74,7 @@ async fn test_create_rule() {
         rule.conditions,
         json!({"equals": {"event.status": "success"}})
     );
-    assert_eq!(rule.enabled, true);
+    assert!(rule.enabled);
     assert!(rule.created.timestamp() > 0);
     assert!(rule.updated.timestamp() > 0);
 }
@@ -117,7 +117,7 @@ async fn test_create_rule_disabled() {
 
     let rule = RuleRepository::create(&pool, input).await.unwrap();
 
-    assert_eq!(rule.enabled, false);
+    assert!(!rule.enabled);
 }
 
 #[tokio::test]
@@ -759,7 +759,7 @@ async fn test_update_rule_enabled() {
         .await
         .unwrap();
 
-    assert_eq!(updated.enabled, false);
+    assert!(!updated.enabled);
 }
 
 #[tokio::test]
@@ -816,7 +816,7 @@ async fn test_update_rule_multiple_fields() {
     assert_eq!(updated.label, "New Label");
     assert_eq!(updated.description, "New Description");
     assert_eq!(updated.conditions, json!({"updated": true}));
-    assert_eq!(updated.enabled, false);
+    assert!(!updated.enabled);
 }
 
 #[tokio::test]

crates/common/tests/sensor_repository_tests.rs

@@ -61,7 +61,7 @@ async fn test_create_sensor_minimal() {
     assert_eq!(sensor.runtime_ref, runtime.r#ref);
     assert_eq!(sensor.trigger, trigger.id);
     assert_eq!(sensor.trigger_ref, trigger.r#ref);
-    assert_eq!(sensor.enabled, true);
+    assert!(sensor.enabled);
     assert_eq!(sensor.param_schema, None);
     assert!(sensor.created.timestamp() > 0);
     assert!(sensor.updated.timestamp() > 0);
@@ -796,7 +796,7 @@ async fn test_update_enabled_status() {
     .await
     .unwrap();
 
-    assert_eq!(sensor.enabled, true);
+    assert!(sensor.enabled);
 
     let input = UpdateSensorInput {
         enabled: Some(false),
@@ -807,7 +807,7 @@ async fn test_update_enabled_status() {
         .await
         .unwrap();
 
-    assert_eq!(updated.enabled, false);
+    assert!(!updated.enabled);
 
     // Enable it again
     let input = UpdateSensorInput {
@@ -819,7 +819,7 @@ async fn test_update_enabled_status() {
         .await
         .unwrap();
 
-    assert_eq!(updated.enabled, true);
+    assert!(updated.enabled);
 }
 
 #[tokio::test]
@@ -924,7 +924,7 @@ async fn test_update_multiple_fields() {
     assert_eq!(updated.label, "Multi Update");
     assert_eq!(updated.description, "Updated multiple fields");
     assert_eq!(updated.entrypoint, "sensors/multi.py");
-    assert_eq!(updated.enabled, false);
+    assert!(!updated.enabled);
     assert_eq!(updated.param_schema, Some(json!({"type": "object"})));
 }
 

crates/common/tests/trigger_repository_tests.rs

@@ -42,7 +42,7 @@ async fn test_create_trigger() {
     assert_eq!(trigger.pack, Some(pack.id));
     assert_eq!(trigger.pack_ref, Some(pack.r#ref));
     assert_eq!(trigger.label, "Webhook Trigger");
-    assert_eq!(trigger.enabled, true);
+    assert!(trigger.enabled);
     assert!(trigger.created.timestamp() > 0);
     assert!(trigger.updated.timestamp() > 0);
 }
@@ -134,7 +134,7 @@ async fn test_create_trigger_disabled() {
 
     let trigger = TriggerRepository::create(&pool, input).await.unwrap();
 
-    assert_eq!(trigger.enabled, false);
+    assert!(!trigger.enabled);
 }
 
 #[tokio::test]
@@ -478,7 +478,7 @@ async fn test_update_trigger() {
     assert_eq!(updated.r#ref, trigger.r#ref); // Ref should not change
     assert_eq!(updated.label, "Updated Label");
     assert_eq!(updated.description, Some("Updated description".to_string()));
-    assert_eq!(updated.enabled, false);
+    assert!(!updated.enabled);
     assert!(updated.updated > original_updated);
 }